Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ipad share #336

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix: ipad share #336

merged 2 commits into from
Dec 9, 2024

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Dec 9, 2024

No description provided.

@aanorbel aanorbel requested a review from sdsantos December 9, 2024 12:18
Comment on lines 190 to 195
if (UI_USER_INTERFACE_IDIOM() == UIUserInterfaceIdiomPad) {
mailComposer.popoverPresentationController?.sourceView = viewController.view

mailComposer.modalPresentationStyle = UIModalPresentationOverCurrentContext
mailComposer.popoverPresentationController?.sourceRect = CGRectMake(0.0, 0.0, 200.0, 200.0)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this code is repeated 3 times, maybe we can create a function for it?

@aanorbel aanorbel merged commit 12d82a0 into main Dec 9, 2024
2 checks passed
@aanorbel aanorbel deleted the fix-ipad-popup branch December 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants